-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make the inserter full height #20526
Conversation
Size Change: -346 B (0%) Total Size: 865 kB
ℹ️ View Unchanged
|
d51b208
to
e940bf6
Compare
e940bf6
to
3e8d524
Compare
Thanks for working on this. I imagine we'll want to use this as the basis going forward. Since working on the last one, I've been thinking that perhaps the treatment of blocks themselves might need a little more work, so I think it would be good to freshen up the mockup and then I can help bring this branch home. |
Noting that this PR is also a requirement before starting to explore showing the block patterns in the inserter. |
Can we merge this and continue iteratively or what needs to be done here? |
Took this branch for a spin, here's a GIF: I do think it's a superior experience, but I'd love @mtias thoughts on it before we merge. I believe he's been thinking about the inserters a lot lately, and might have thoughts. If we do go forward with this branch (I'm a fan), then two things:
|
This feels vastly better than what we have. On an "averagely sized" window, it looks great: I'm however not a fan of all the empty space when the window is taller than average: @jasmussen not sure if you've put any thought on this. I myself I'm undecided on how to go about this and if it's a big issue at all. @youknowriad I think I found a minor bug: when increasing my browser's window height, the inserter does not accurately grow in proportion to the window: |
I think it's not a big issue, but I definitely hear you, it's something to consider. The reason for the very tall inserter, outside of just leveraging the space, is because people don't scroll and discover more blocks. I would suggest that's an argument to explore collapsing only some of the block sections, like Embeds perhaps, and then defaulting more categories to open. |
|
e2ec7c1
to
b820f5f
Compare
did some cleanup here and rebased, it should be good. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Design wise, this does what expect it to. I will note that as the breadcrumbs become more important, potentially not overlapping those could be an iteration. That said, let's get this in so removing the design feedback label for now.
Let's try that. |
Alternative to #19836
Tries to accomplish the same result with smaller changes that work across inserters.